diff --git a/src/Http/Controllers/TicketController.php b/src/Http/Controllers/TicketController.php index aca81de..c597662 100644 --- a/src/Http/Controllers/TicketController.php +++ b/src/Http/Controllers/TicketController.php @@ -5,6 +5,7 @@ namespace Dashboard\Ticketing\Http\Controllers; use App\Models\Setting; use App\Models\User; use App\Support\PersonChip; +use App\Support\PersonNames; use Dashboard\Ticketing\Models\PriorityLevel; use Dashboard\Ticketing\Models\Ticket; use Dashboard\Ticketing\Models\TicketAttachment; @@ -1132,11 +1133,23 @@ class TicketController extends Controller * operator-precedence hole the same shape opened on [central-inventory] * #1594. * - * `orderBy('name')` is new and is the only visible difference: the old query - * had no order at all, so ten rows arrived in whatever order the storage - * engine happened to return them and the same two letters could list the - * same people differently twice running. The reference search orders by - * name, and "a consistent shape" is what this card is for. + * AN ORDER AT ALL is new, and it is `PersonNames::orderUsers()` rather than + * `orderBy('name')`. The old query had no order, so ten rows arrived in + * whatever sequence the storage engine happened to return them and the same + * two letters could list the same people differently twice running. But the + * column that makes an order CONSISTENT is not automatically the one that + * makes it READABLE: `users.name` is the cached "First Last" ("Andrew Fast") + * and these rows are chips, which read "Last, First" ("Fast, Andrew"). A + * list labelled one way and collated the other is what an operator calls + * unsorted — "Toews, Fast, Ivanov, Mwangi, Bergman" is perfectly ordered by + * a string the row no longer shows. `PersonNames::orderUsers()` is the + * platform's one answer to that (#524), it is what the reference search + * (`admin.settings.users.search`) and the sibling conversions use, and it + * honours the operator's `name_format` rather than assuming surname-first. + * + * It also decides WHICH TEN come back, not merely their sequence, so this is + * not cosmetic: on a common surname the limit falls on a different set of + * people under the two collations. */ public function searchUsers(Request $request, Ticket $ticket) { @@ -1161,7 +1174,7 @@ class TicketController extends Controller ->orWhere('email', 'like', "%{$q}%"); }) ->whereNotIn('id', $excludeIds) - ->orderBy('name') + ->tap(fn ($query) => PersonNames::orderUsers($query)) ->limit(10) ->get(PersonChip::columns()) ));