jwed/central-ticketing
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

The singular delete-flash agrees with itself: "so it stays usable" (#1567)

Browse Source 
deletionFlash() pluralised the count, the noun, the auxiliary and the
pronoun, but left the verb fixed at "stay" — so the singular branch, which
is the common one, shipped "1 ticket was merged into it ... so it stay
usable".

The verb agrees with the pronoun, so it belongs in the same ternary:
"it stays" / "they stay". Nothing else about the message changes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
central-worker-1
2026-09-11 14:04:16 -07:00
parent 2b6d9b1651
commit ab309a3898
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Http/Controllers/TicketController.php
View File

@@ -741,12 +741,14 @@ class TicketController extends Controller
if ($handled['unmerged'] !== []) { if ($handled['unmerged'] !== []) {
$parts[] = sprintf( $parts[] = sprintf(
'%s %s merged into it and %s been un-merged (status %s) so %s stay usable: %s.', '%s %s merged into it and %s been un-merged (status %s) so %s usable: %s.',
count($handled['unmerged']), count($handled['unmerged']),
count($handled['unmerged']) === 1 ? 'ticket was' : 'tickets were', count($handled['unmerged']) === 1 ? 'ticket was' : 'tickets were',
count($handled['unmerged']) === 1 ? 'has' : 'have', count($handled['unmerged']) === 1 ? 'has' : 'have',
Ticket::STATUS_UNMERGED, Ticket::STATUS_UNMERGED,
count($handled['unmerged']) === 1 ? 'it' : 'they', // The verb agrees with the pronoun, so it lives in the same ternary:
// "so it stays usable" / "so they stay usable".
count($handled['unmerged']) === 1 ? 'it stays' : 'they stay',
implode(', ', $handled['unmerged']), implode(', ', $handled['unmerged']),
); );
} }